Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gm/remove produces blinded blocks #393

Merged
merged 28 commits into from
May 20, 2024
Merged

Gm/remove produces blinded blocks #393

merged 28 commits into from
May 20, 2024

Conversation

guym-blox
Copy link
Contributor

@guym-blox guym-blox commented May 6, 2024 •
edited
Loading

Since attestantio/go-eth2-client#116 GetBeaconBlock can return both proposal and blinded proposal.

This PR

removes the logic which eth2 client endpoint to choose
always uses GetBeaconBlock instead

@guym-blox guym-blox marked this pull request as ready for review May 8, 2024 12:26
y0sher
y0sher approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@y0sher y0sher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GalRogozinski please check this out

MatheusFranco99
MatheusFranco99 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@MatheusFranco99 MatheusFranco99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GalRogozinski
GalRogozinski reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
just return the whitespace

ssv/spectest/tests/runner/postconsensus/quorum_7_operators.go Outdated Show resolved Hide resolved
@GalRogozinski GalRogozinski merged commit 4d21044 into main May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0sher y0sher y0sher approved these changes

@GalRogozinski GalRogozinski GalRogozinski approved these changes

@MatheusFranco99 MatheusFranco99 MatheusFranco99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guym-blox @y0sher @GalRogozinski @MatheusFranco99 @moshe-blox